Skip to content

Commit

Permalink
♻️ Name docs artifacts by repo-name instead of package name (#42)
Browse files Browse the repository at this point in the history
  • Loading branch information
falexwolf authored Sep 7, 2024
1 parent b0fcaad commit 82d0839
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
7 changes: 2 additions & 5 deletions laminci/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Internal CI tools.
"""Lamin's CI tools.
Import the package::
Expand All @@ -9,12 +9,9 @@
__version__ = "0.14.0" # denote a pre-release for 0.1.0 with 0.1a1

from . import db, nox
from ._artifacts import upload_docs_artifact
from ._docs import (
move_built_docs_to_docs_slash_project_slug,
move_built_docs_to_slash_project_slug,
)
from ._docs_artifacts import upload_docs_artifact
from ._env import get_package_name, get_schema_handle

# backward compat
upload_docs_dir = upload_docs_artifact
17 changes: 9 additions & 8 deletions laminci/_artifacts.py → laminci/_docs_artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

from lamin_utils import logger

from ._env import get_package_name


def zip_docs_dir(zip_filename: str) -> None:
with ZipFile(zip_filename, "w") as zf:
Expand All @@ -20,28 +18,31 @@ def zip_docs_dir(zip_filename: str) -> None:


def zip_docs():
package_name = get_package_name()
zip_filename = f"{package_name}_docs.zip"
repo_name = Path.cwd().name
assert repo_name.suffix == "" # doesn't have a weird suffix
assert Path(".git/").exists() # is git repo
assert repo_name.lower() == repo_name # is all lower-case
zip_filename = f"{repo_name}.zip"
zip_docs_dir(zip_filename)
return package_name, zip_filename
return repo_name, zip_filename


def upload_docs_artifact_aws() -> None:
package_name, zip_filename = zip_docs()
repo_name, zip_filename = zip_docs()
run(
f"aws s3 cp {zip_filename} s3://lamin-site-assets/docs/{zip_filename}",
shell=True,
)


def upload_docs_artifact_lamindb() -> None:
package_name, zip_filename = zip_docs()
repo_name, zip_filename = zip_docs()

import lamindb as ln

ln.setup.load("testuser1/lamin-site-assets", migrate=True)

transform = ln.add(ln.Transform, name=f"CI {package_name}")
transform = ln.add(ln.Transform, name=f"CI {repo_name}")
ln.track(transform=transform)

file = ln.select(ln.File, key=f"docs/{zip_filename}").one_or_none()
Expand Down

0 comments on commit 82d0839

Please sign in to comment.