Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically make Github releases #28

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Automatically make Github releases #28

merged 7 commits into from
Nov 23, 2023

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 21, 2023

Fixes #27

Approach:

  1. Use gh if installed to use the set token cross-platform.
  2. Else use PyGithub if installed. Check for GITHUB_TOKEN environment variable which commonly also stores the token.
  3. If also not available, ask user for input.
    Fail if neither of the two available.

Tested in a separate repository:

image

@Zethson Zethson marked this pull request as draft November 21, 2023 12:28
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@Zethson Zethson marked this pull request as ready for review November 23, 2023 16:49
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@Zethson Zethson requested a review from falexwolf November 23, 2023 17:14
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😄

@Zethson Zethson merged commit ba9c32b into main Nov 23, 2023
@Zethson Zethson deleted the feature/gh_release branch November 23, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically create Github releases
2 participants