Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish() support for CI environments #1851

Open
Zethson opened this issue Aug 27, 2024 · 0 comments
Open

finish() support for CI environments #1851

Zethson opened this issue Aug 27, 2024 · 0 comments
Labels

Comments

@Zethson
Copy link
Member

Zethson commented Aug 27, 2024

ln.finish() errors with the "must save notebook" error when run on CI. I got confused earlier why this wasn't working to have to learn that it simply doesn't support CI because we cannot manually save the notebook there.

  1. I would suggest that we document this behavior better.
  2. I would suggest that we detect CI environments (environment variables) and provide a different error message stating that this is not supported.
@Zethson Zethson changed the title finish support for CI environments finish() support for CI environments Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant