Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Confusing name: Curate.add_validated_from #1860

Open
falexwolf opened this issue Aug 28, 2024 · 2 comments
Open

🎨 Confusing name: Curate.add_validated_from #1860

falexwolf opened this issue Aug 28, 2024 · 2 comments
Assignees

Comments

@falexwolf
Copy link
Member

The problem with the below is that values in a public ontology are not validated in the LaminDB definition. Hence, the name of the method is highly confusing.

image

How shall this method be called?

@falexwolf falexwolf changed the title Confusing name add_validated_from 🎨 Confusing name: Curate.add_validated_from Aug 28, 2024
@falexwolf
Copy link
Member Author

This here is still a quite basic thing that we should get resolved, shouldn't we? I think you wanted to work on it at some point @Zethson?

@Zethson
Copy link
Member

Zethson commented Sep 27, 2024

I'll think about it next week but if we change the default of Curator to also validate against records without a Source record even if a Source is passed, the comment above would certainly be false and the name fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants