✨ Support auto-knitted html reports during ln.finish()
#2213
+42
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
ln.finish()
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2213 +/- ##
==========================================
+ Coverage 92.36% 92.92% +0.55%
==========================================
Files 54 54
Lines 6566 6826 +260
==========================================
+ Hits 6065 6343 +278
+ Misses 501 483 -18 ☔ View full report in Codecov by Sentry. |
falexwolf
commented
Nov 29, 2024
| run.save() | ||
| else: | ||
| if not from_cli: | ||
| if get_seconds_since_modified(filepath) > 2 and not ln_setup._TESTING: | ||
| # this can happen when auto-knitting an html with RStudio |
There was a problem hiding this comment.
Creating a test setup for this is a bit more cumbersome, I will ship once I know this is meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These auto-knitted reports come with the
.nb.htmlsuffix.Resolves:
db$track()in RStudio laminr#110Considered also supporting
.nb.htmlfor the CLI but concluded that it'd be more dangerous than beneficial:.nb.htmlsuffix duringlamin savelamin-cli#97