Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash inconsistency between calling db$finish() and knitting the html #104

Closed
falexwolf opened this issue Nov 22, 2024 · 4 comments
Closed
Assignees

Comments

@falexwolf
Copy link
Member

Upon knitting the html and no changes to the source code, we don't want throw an error and require bumping the version.

This is likely an issue within lamindb where it does this because it assumes re-execution will change the source code hash.

I'll look into this.

@falexwolf falexwolf self-assigned this Nov 22, 2024
@falexwolf
Copy link
Member Author

Probably not. Probably @rcannood made a small change to the source code between knitting and calling db$finish()

The .Rmd is currently categorized as a "script" because Robrecht used lamindb 0.76.16 and I only fixed this in lamindb 0.77
image

@falexwolf falexwolf changed the title Streamline workflow for creating the html Hash inconsistency between calling db$finish() and knitting the html Nov 25, 2024
@falexwolf
Copy link
Member Author

Never calling db$finish() interactively would solve the problem.

@lazappi
Copy link
Collaborator

lazappi commented Dec 4, 2024

I think this is fixed by #120

@falexwolf
Copy link
Member Author

I also think so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants