Add a simple unit test which queries laminlabs/lamindata #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazappi
requested changes
Oct 10, 2024
Comment on lines
2
to
4
| temp_lamin_dir <- tempfile() | ||
| temp_lamin_dir2 <- file.path(temp_lamin_dir, ".lamin") | ||
| dir.create(temp_lamin_dir2, recursive = TRUE, showWarnings = FALSE) |
There was a problem hiding this comment.
Could you just use tempdir() here?
There was a problem hiding this comment.
No -- because tempdir() is a temporary directory that is created once per R session, so calling tempdir() multiple times results in the same result.
Comment on lines
2
to
41
| temp_lamin_dir <- tempfile() | ||
| temp_lamin_dir2 <- file.path(temp_lamin_dir, ".lamin") | ||
| dir.create(temp_lamin_dir2, recursive = TRUE, showWarnings = FALSE) | ||
| Sys.setenv(LAMIN_SETTINGS_DIR = temp_lamin_dir) | ||
| on.exit({ | ||
| unlink(temp_lamin_dir, recursive = TRUE) | ||
| Sys.unsetenv("LAMIN_SETTINGS_DIR") | ||
| }) | ||
|
|
||
| # generate user settings | ||
| user_settings <- list( | ||
| email = "null", | ||
| password = "null", | ||
| access_token = "null", | ||
| api_key = "null", | ||
| uid = "00000000", | ||
| uuid = "null", | ||
| handle = "anonymous", | ||
| name = "null" | ||
| ) | ||
| user_lines <- paste0("lamin_user_", names(user_settings), "=", unlist(user_settings)) | ||
| writeLines(user_lines, file.path(temp_lamin_dir2, "current_user.env")) | ||
|
|
||
| # generate instance settings | ||
| instance_settings <- list( | ||
| owner = "laminlabs", | ||
| name = "lamindata", | ||
| api_url = "https://us-east-1.api.lamin.ai", | ||
| storage_root = "s3://lamindata", | ||
| storage_region = "us-east-1", | ||
| db = "null", | ||
| schema_str = "bionty,wetlab", | ||
| schema_id = "097186c3e91c01ced47aa3e01a3c1515", | ||
| id = "037ba1e08d804f91a90275a47735076a", | ||
| git_repo = "null", | ||
| keep_artifacts_local = "False" | ||
| ) | ||
| instance_lines <- paste0("lamindb_instance_", names(instance_settings), "=", unlist(instance_settings)) | ||
| writeLines(instance_lines, file.path(temp_lamin_dir2, "current_instance.env")) | ||
| writeLines(instance_lines, file.path(temp_lamin_dir2, "instance--laminlabs--lamindata.env")) |
There was a problem hiding this comment.
In future it might make sense to make this setup into a fixture so it can be reused but probably not worth the effort now.
|
Thanks for the great feedback @lazappi ! |
lazappi
added a commit
that referenced
this pull request
Oct 14, 2024
* origin/main: Add printing to remaining classes (#31) Improve error messages (#30) Update documentation (#29) Return `NULL` when a record's related field is empty (#28) minor fix in usage vignette (#32) Add usage vignette (#18) Add a simple unit test which queries laminlabs/lamindata (#27) bump action from v4.5.0 to v4 (#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Minor changes