Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version, add luke as an author #39

Merged
merged 5 commits into from
Oct 16, 2024
Merged

update version, add luke as an author #39

merged 5 commits into from
Oct 16, 2024

Conversation

rcannood
Copy link
Collaborator

@rcannood rcannood commented Oct 14, 2024 •
edited
Loading

Make a couple of changes to the docs

@rcannood rcannood requested a review from lazappi October 15, 2024 07:33
lazappi
lazappi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@lazappi lazappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There was a comment from Lukas about matching the Lamin format for the CHANGELOG. Not sure what is involved there and/or if we want a separate NEWS file to summarise the release for CRAN.

@rcannood
Copy link
Collaborator Author

I'm okay with changing the format of the changelog, but let's do that in a separate PR so we can merge this already ^^

@rcannood rcannood merged commit 974c7c5 into main Oct 16, 2024
7 checks passed
@rcannood rcannood deleted the prepare_release branch October 16, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazappi lazappi lazappi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcannood @lazappi