Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar #58

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add progress bar #58

merged 2 commits into from
Oct 25, 2024

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Oct 24, 2024

Set progress = TRUE in Artifact$cache()

@lazappi lazappi requested a review from rcannood October 24, 2024 08:50
@lazappi lazappi mentioned this pull request Oct 24, 2024
Closed
@rcannood
Copy link
Collaborator

Thanks for taking care of this!

Does the python interface expose an argument to be able to turn this off and on?

@lazappi
Copy link
Collaborator Author

lazappi commented Oct 24, 2024

I don't think so but it would be easy enough to add one if you like

@rcannood
Copy link
Collaborator

Alright!

  • Could you add an entry to the changelog?

  • Can you look into why macos is failing? (probably unrelated)

@lazappi
Copy link
Collaborator Author

lazappi commented Oct 24, 2024 

* Can you look into why macos is failing? (probably unrelated)

I think this is a scipy thing, I opened an issue about it already #57

@lazappi lazappi merged commit ab0f303 into main Oct 25, 2024
6 of 7 checks passed
@lazappi lazappi deleted the issue-45/add-progress branch October 25, 2024 06:27
lazappi added a commit that referenced this pull request Oct 25, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into issue-52/remove-linkt…
330d1d9 
…ables

* origin/main:
  Add progress bar (#58)
  Add get_records() to API and df() to Registry (#54)
lazappi added a commit that referenced this pull request Oct 25, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into issues-46-47/check-su…
2c497ce 
…ggests

* origin/main:
  Remove link tables from print output (#55)
  Add progress bar (#58)
  Add get_records() to API and df() to Registry (#54)
lazappi added a commit that referenced this pull request Oct 28, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into issue-48/add-RecordsList
8b21e73 
* origin/main:
  Remove link tables from print output (#55)
  Add progress bar (#58)
  Add get_records() to API and df() to Registry (#54)
lazappi added a commit that referenced this pull request Oct 31, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into issue-49/adjust-print…
c392824 
…-colours

* origin/main:
  Add Records container class (#59)
  Refactor documentation (#67)
  Fix macOS runner (#66)
  Add check_requires() function and update installation docs (#56)
  Remove link tables from print output (#55)
  Add progress bar (#58)
  Add get_records() to API and df() to Registry (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazappi @rcannood