Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow connecting to private LaminDB instances #118

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Allow connecting to private LaminDB instances #118

merged 7 commits into from
Nov 28, 2024

Conversation

rcannood
Copy link
Collaborator

@rcannood rcannood commented Nov 27, 2024 •
edited
Loading

Related to:

Description

Fixes the instance API to allow connecting to private LaminDB instances to work

Checklist

Before review

  • Update and regenerate man pages
  • Add/update tests
  • Add/update examples in vignettes
  • Pass CI checks

Before merge

  • Update architecture vignette
  • Update development vignette
  • Update features in README
  • Update CHANGELOG

@falexwolf
Copy link
Member

Can you add a test that connects to laminlabs/lamin-dev, please? So that this doesn't break in the future?

@falexwolf
Copy link
Member

And then we'll hopefully release this to CRAN tomorrow afternoon or Friday.

lazappi
lazappi reviewed Nov 28, 2024
View reviewed changes
R/InstanceAPI.R Outdated Show resolved Hide resolved
@lazappi lazappi merged commit b13e03b into main Nov 28, 2024
7 checks passed
@lazappi lazappi deleted the authenticate-api branch November 28, 2024 09:45
lazappi added a commit that referenced this pull request Nov 28, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into falexwolf-patch-1
e40ca32 
* origin/main:
  Allow connecting to private LaminDB instances (#118)
  Use host system user for running tests (#119)
  update changelog and version
  update roadmap (#112)
  Update `get-started` with resolutions of questions from demo (#113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazappi lazappi lazappi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcannood @falexwolf @lazappi