Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Simplify use case, move to nf-core/scrnaseq #42

Merged
merged 47 commits into from
Oct 3, 2024
Merged

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Sep 26, 2024

  • Moves to nf-core/rnaseq
  • Adds more useful intro text on how to best use Nextflow with lamindb
  • Uses clear functions for the registration to simplify the process
Before After

Signed-off-by: zethson <[email protected]>
@Zethson Zethson marked this pull request as draft September 26, 2024 09:27
Copy link

github-actions bot commented Sep 26, 2024

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 14:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 14:26 Inactive
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 10:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 13:31 Inactive
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9a9edc5) to head (aec7586).
Report is 15 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #42   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          1       1           
=====================================
  Misses         1       1           
Flag Coverage Δ
0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 13:50 Inactive
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 14:02 Inactive
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 14:14 Inactive
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 14:24 Inactive
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 27, 2024 14:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 12:05 Inactive
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 12:22 Inactive
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 12:47 Inactive
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
@Zethson Zethson marked this pull request as ready for review October 1, 2024 13:12
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 13:21 Inactive
Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 13:41 Inactive
@falexwolf
Copy link
Member

This is great! It's very easy to understand & makes total sense now.

The only confusing thing is that you're using ln.track() within the registration (aka wrapper/glue) script.

I think it'd make more sense to simply create a run object and annotating it with inputs, outputs, and the correct timestamps.

ln.track() really is built for notebooks & scripts that serve the role of a data transformation. But here we're working with a mere registration/wrapper/glue script.

@falexwolf
Copy link
Member

Hence, I refactored the script a bit. What's missing is adding the correct timestamps.

I'll look into the JSON field issue tomorrow. 505 lines of JSON 🤯 ...

@falexwolf
Copy link
Member

Sorry for breaking things, @Zethson. I hope this refactor fixes it.

Will work on the JSON issue now.

@Zethson
Copy link
Member Author

Zethson commented Oct 2, 2024

@falexwolf it didn't. Something in the script must still be wrong. I will look into it after breakfast while you're looking at the JSON stuff.

@falexwolf
Copy link
Member

falexwolf commented Oct 2, 2024

Had to spend time on the UI. Will now look into the JSON topic.

Signed-off-by: zethson <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 13:54 Inactive
@Zethson Zethson changed the title 🎨 Simplify use case 🎨 Simplify use case by moving to nf-core/scrnaseq Oct 3, 2024
@Zethson Zethson merged commit a7bbf2d into main Oct 3, 2024
2 checks passed
@Zethson Zethson deleted the feature/simplify branch October 3, 2024 07:59
@falexwolf falexwolf changed the title 🎨 Simplify use case by moving to nf-core/scrnaseq 🎨 Simplify use case, move to nf-core/scrnaseq Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants