-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Simplify use case, move to nf-core/scrnaseq
#42
Conversation
Zethson
commented
Sep 26, 2024
•
edited
Loading
edited
- Moves to nf-core/rnaseq
- Adds more useful intro text on how to best use Nextflow with lamindb
- Uses clear functions for the registration to simplify the process
Before | After |
---|---|
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 1 1
=====================================
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
This is great! It's very easy to understand & makes total sense now. The only confusing thing is that you're using I think it'd make more sense to simply create a
|
Hence, I refactored the script a bit. What's missing is adding the correct timestamps. I'll look into the JSON field issue tomorrow. 505 lines of JSON 🤯 ... |
Sorry for breaking things, @Zethson. I hope this refactor fixes it. Will work on the JSON issue now. |
@falexwolf it didn't. Something in the script must still be wrong. I will look into it after breakfast while you're looking at the JSON stuff. |
Had to spend time on the UI. Will now look into the JSON topic. |
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
nf-core/scrnaseq