Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phong shading #2

Open
andeplane opened this issue Aug 8, 2017 · 0 comments
Open

Add phong shading #2

andeplane opened this issue Aug 8, 2017 · 0 comments
Assignees
Milestone

Comments

@andeplane
Copy link
Collaborator

Current shading is very simple and not so pretty, so we should add phong shading.

If we want to enable bond rendering between atoms, we will need the ray traced shading like we have in Atomify. The only problem is that three.js doesn't let us override vertexPosition in the fragment shader for shading, so we need to add an issue / create a PR so this is supported.

For version 1.0 we can simply just use the lighting three.js has and interpolate vertexPosition the regular way.

@andeplane andeplane added this to the 1.0 milestone Aug 8, 2017
@andeplane andeplane self-assigned this Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant