Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set uBit.io.logo to capacitive touch mode by default. #418

Merged
merged 1 commit into from
May 21, 2024

Conversation

microbit-carlos
Copy link
Collaborator

@finneyj this would be the simplest way set the io.logo pin capacitive, do you think it should be behind a build flag as well? If so, what would be the best name for it? MICROBIT_PIN_LOGO_CAPACITIVE?
In that case we would still like to make sure the default value is set to capacitive, so the flag would be mostly used to disable this feature?

Copy link

Build diff

Base commit: 9a03c691c12474852819843f21e32908ab405a2f
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/8453920050

     VM SIZE    
 -------------- 
  +0.8%     +20    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-microbit-v2/model/MicroBit.cpp
  -0.0%      -4    [section .text]
  +0.0%     +16    TOTAL

@microbit-carlos
Copy link
Collaborator Author

We can change the state of the io pin to configure the capacitive state without running the ADC and any background events that might be triggered.

Without initialising the touch engine in the background.
Copy link

Build diff

Base commit: a3492c4378be02a0071721dbc5a7164840be5a11
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/9176454307

     VM SIZE    
 -------------- 
  +0.5%     +12    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-microbit-v2/model/MicroBit.cpp
  -0.1%     -12    [section .text]
  [ = ]       0    TOTAL

Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on a call with @finneyj and ready to be merged.

@microbit-carlos microbit-carlos merged commit 8c8db00 into master May 21, 2024
29 checks passed
@microbit-carlos microbit-carlos deleted the io-logo-capacitive branch May 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant