Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the namespace #26

Open
lancew opened this issue Apr 6, 2016 · 5 comments
Open

Clean the namespace #26

lancew opened this issue Apr 6, 2016 · 5 comments

Comments

@lancew
Copy link
Owner

lancew commented Apr 6, 2016

As raspass mentioned, Usage: Time::HiRes::time() is now unintentionally a method of Scientist.

So $experiment->time;

This would produce something like "Usage: Time::HiRes::time()"

Propose: use namespace::clean; ?

@jkeroes
Copy link

jkeroes commented Apr 6, 2016

works for me.

@lancew
Copy link
Owner Author

lancew commented Apr 6, 2016

Just pushed a branch with the above proposed solution (and a not terribly clever test).

@jkeroes
Copy link

jkeroes commented Apr 7, 2016

This works. For the testing, what do you think about:

ok(! $CLASS->can("time"), 'should not have time()');

@JRaspass
Copy link
Collaborator

JRaspass commented Apr 7, 2016

WebDriver::Tiny has a super simple, yet exhaustive, namespace test - https://github.com/cv-library/WebDriver-Tiny/blob/master/t/namespace.t

@lancew
Copy link
Owner Author

lancew commented Apr 8, 2016

Pushed a new commit... 5962bf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants