You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
INTPYTHON-787 Added check for AZURE_OPENAI_ENDPOINT test_graphrag.py and cleaned up closing clients (#232)
[Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY})
## Summary
<!-- What is this PR introducing? If context is already provided from
the JIRA ticket, still place it in the Pull Request as you should not
make the reviewer do digging for a basic summary. -->
## Changes in this PR
<!-- What changes did you make to the code? What new APIs (public or
private) were added, removed, or edited to generate the desired outcome
explained in the above summary? -->
This is a small bugfix. When we switched from including OPENAI_API_KEY
in CI secrets to using AZURE_OPENAI_ENDPOINTS, we missed this one.
## Test Plan
<!-- How did you test the code? If you added unit tests, you can say
that. If you didn’t introduce unit tests, explain why. All code should
be tested in some way – so please list what your validation strategy
was. -->
- Tests are run in github and evergreen. A passing patch build will be
included.
## Checklist
<!-- Do not delete the items provided on this checklist -->
### Checklist for Author
- [ na] Did you update the changelog (if necessary)?
- [X] Is the intention of the code captured in relevant tests?
- [na] If there are new TODOs, has a related JIRA ticket been created?
- [X] Has a MongoDB Employee run [the patch build of this
PR](https://github.com/mongodb-labs/ai-ml-pipeline-testing?tab=readme-ov-file#running-a-patch-build-of-a-given-pr)?
### Checklist for Reviewer {@primary_reviewer}
- [x] Does the title of the PR reference a JIRA Ticket?
- [x] Do you fully understand the implementation? (Would you be
comfortable explaining how this code works to someone else?)
- [x] Have you checked for spelling & grammar errors?
- [x] Is all relevant documentation (README or docstring) updated?
## Focus Areas for Reviewer (optional)
<!-- List any complex portion of code you believe needs particular
scrutiny and explain why. -->
The author had thought of updating MongoDBGraphStore to be a context
manager. All this would do is close the client. We decided to leave it
with a close method only.
0 commit comments