Skip to content

Commit d83c3a1

Browse files
authored
chore(core): delete BaseMemory, move to langchain-classic (#33373)
1 parent 79200cf commit d83c3a1

File tree

15 files changed

+17
-16
lines changed

15 files changed

+17
-16
lines changed

libs/langchain/langchain_classic/agents/agent_toolkits/conversational_retrieval/openai_functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from typing import Any
22

33
from langchain_core.language_models import BaseLanguageModel
4-
from langchain_core.memory import BaseMemory
54
from langchain_core.messages import SystemMessage
65
from langchain_core.prompts.chat import MessagesPlaceholder
76
from langchain_core.tools import BaseTool
@@ -11,6 +10,7 @@
1110
AgentTokenBufferMemory,
1211
)
1312
from langchain_classic.agents.openai_functions_agent.base import OpenAIFunctionsAgent
13+
from langchain_classic.base_memory import BaseMemory
1414
from langchain_classic.memory.token_buffer import ConversationTokenBufferMemory
1515

1616

libs/core/langchain_core/memory.py renamed to libs/langchain/langchain_classic/base_memory.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@
1010
from abc import ABC, abstractmethod
1111
from typing import Any
1212

13-
from pydantic import ConfigDict
14-
1513
from langchain_core._api import deprecated
1614
from langchain_core.load.serializable import Serializable
1715
from langchain_core.runnables import run_in_executor
16+
from pydantic import ConfigDict
1817

1918

2019
@deprecated(

libs/langchain/langchain_classic/chains/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
CallbackManagerForChainRun,
2121
Callbacks,
2222
)
23-
from langchain_core.memory import BaseMemory
2423
from langchain_core.outputs import RunInfo
2524
from langchain_core.runnables import (
2625
RunnableConfig,
@@ -38,6 +37,7 @@
3837
)
3938
from typing_extensions import override
4039

40+
from langchain_classic.base_memory import BaseMemory
4141
from langchain_classic.schema import RUN_KEY
4242

4343
logger = logging.getLogger(__name__)

libs/langchain/langchain_classic/chains/conversation/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
"""Chain that carries on a conversation and calls an LLM."""
22

33
from langchain_core._api import deprecated
4-
from langchain_core.memory import BaseMemory
54
from langchain_core.prompts import BasePromptTemplate
65
from pydantic import ConfigDict, Field, model_validator
76
from typing_extensions import Self, override
87

8+
from langchain_classic.base_memory import BaseMemory
99
from langchain_classic.chains.conversation.prompt import PROMPT
1010
from langchain_classic.chains.llm import LLMChain
1111
from langchain_classic.memory.buffer import ConversationBufferMemory

libs/langchain/langchain_classic/memory/buffer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
from typing import Any
22

33
from langchain_core._api import deprecated
4-
from langchain_core.memory import BaseMemory
54
from langchain_core.messages import BaseMessage, get_buffer_string
65
from langchain_core.utils import pre_init
76
from typing_extensions import override
87

8+
from langchain_classic.base_memory import BaseMemory
99
from langchain_classic.memory.chat_memory import BaseChatMemory
1010
from langchain_classic.memory.utils import get_prompt_input_key
1111

libs/langchain/langchain_classic/memory/chat_memory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
BaseChatMessageHistory,
88
InMemoryChatMessageHistory,
99
)
10-
from langchain_core.memory import BaseMemory
1110
from langchain_core.messages import AIMessage, HumanMessage
1211
from pydantic import Field
1312

13+
from langchain_classic.base_memory import BaseMemory
1414
from langchain_classic.memory.utils import get_prompt_input_key
1515

1616

libs/langchain/langchain_classic/memory/combined.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import warnings
22
from typing import Any
33

4-
from langchain_core.memory import BaseMemory
54
from pydantic import field_validator
65

6+
from langchain_classic.base_memory import BaseMemory
77
from langchain_classic.memory.chat_memory import BaseChatMemory
88

99

libs/langchain/langchain_classic/memory/readonly.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from typing import Any
22

3-
from langchain_core.memory import BaseMemory
3+
from langchain_classic.base_memory import BaseMemory
44

55

66
class ReadOnlySharedMemory(BaseMemory):

libs/langchain/langchain_classic/memory/simple.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
from typing import Any
22

3-
from langchain_core.memory import BaseMemory
43
from typing_extensions import override
54

5+
from langchain_classic.base_memory import BaseMemory
6+
67

78
class SimpleMemory(BaseMemory):
89
"""Simple Memory.

libs/langchain/langchain_classic/memory/vectorstore.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55

66
from langchain_core._api import deprecated
77
from langchain_core.documents import Document
8-
from langchain_core.memory import BaseMemory
98
from langchain_core.vectorstores import VectorStoreRetriever
109
from pydantic import Field
1110

11+
from langchain_classic.base_memory import BaseMemory
1212
from langchain_classic.memory.utils import get_prompt_input_key
1313

1414

0 commit comments

Comments
 (0)