From b1f0ebdd815a3aebb6bb7901df792024b3bb27ee Mon Sep 17 00:00:00 2001 From: Mason Daugherty Date: Wed, 8 Oct 2025 23:43:24 -0400 Subject: [PATCH 1/2] chore(core): delete --- libs/core/langchain_core/retrievers.py | 90 -------------------------- 1 file changed, 90 deletions(-) diff --git a/libs/core/langchain_core/retrievers.py b/libs/core/langchain_core/retrievers.py index a0ad0ba876cc9..9650896e6ce91 100644 --- a/libs/core/langchain_core/retrievers.py +++ b/libs/core/langchain_core/retrievers.py @@ -29,8 +29,6 @@ from pydantic import ConfigDict from typing_extensions import Self, TypedDict, override -from langchain_core._api import deprecated -from langchain_core.callbacks import Callbacks from langchain_core.callbacks.manager import AsyncCallbackManager, CallbackManager from langchain_core.documents import Document from langchain_core.runnables import ( @@ -369,91 +367,3 @@ async def _aget_relevant_documents( query, run_manager=run_manager.get_sync(), ) - - @deprecated(since="0.1.46", alternative="invoke", removal="1.0") - def get_relevant_documents( - self, - query: str, - *, - callbacks: Callbacks = None, - tags: list[str] | None = None, - metadata: dict[str, Any] | None = None, - run_name: str | None = None, - **kwargs: Any, - ) -> list[Document]: - """Retrieve documents relevant to a query. - - Users should favor using `.invoke` or `.batch` rather than - `get_relevant_documents directly`. - - Args: - query: string to find relevant documents for. - callbacks: Callback manager or list of callbacks. Defaults to `None`. - tags: Optional list of tags associated with the retriever. - These tags will be associated with each call to this retriever, - and passed as arguments to the handlers defined in `callbacks`. - Defaults to `None`. - metadata: Optional metadata associated with the retriever. - This metadata will be associated with each call to this retriever, - and passed as arguments to the handlers defined in `callbacks`. - Defaults to `None`. - run_name: Optional name for the run. Defaults to `None`. - kwargs: Additional arguments to pass to the retriever. - - Returns: - List of relevant documents. - """ - config: RunnableConfig = {} - if callbacks: - config["callbacks"] = callbacks - if tags: - config["tags"] = tags - if metadata: - config["metadata"] = metadata - if run_name: - config["run_name"] = run_name - return self.invoke(query, config, **kwargs) - - @deprecated(since="0.1.46", alternative="ainvoke", removal="1.0") - async def aget_relevant_documents( - self, - query: str, - *, - callbacks: Callbacks = None, - tags: list[str] | None = None, - metadata: dict[str, Any] | None = None, - run_name: str | None = None, - **kwargs: Any, - ) -> list[Document]: - """Asynchronously get documents relevant to a query. - - Users should favor using `.ainvoke` or `.abatch` rather than - `aget_relevant_documents directly`. - - Args: - query: string to find relevant documents for. - callbacks: Callback manager or list of callbacks. - tags: Optional list of tags associated with the retriever. - These tags will be associated with each call to this retriever, - and passed as arguments to the handlers defined in `callbacks`. - Defaults to `None`. - metadata: Optional metadata associated with the retriever. - This metadata will be associated with each call to this retriever, - and passed as arguments to the handlers defined in `callbacks`. - Defaults to `None`. - run_name: Optional name for the run. Defaults to `None`. - kwargs: Additional arguments to pass to the retriever. - - Returns: - List of relevant documents. - """ - config: RunnableConfig = {} - if callbacks: - config["callbacks"] = callbacks - if tags: - config["tags"] = tags - if metadata: - config["metadata"] = metadata - if run_name: - config["run_name"] = run_name - return await self.ainvoke(query, config, **kwargs) From 1293a425c98fc93a2bf67da555990fc7ef07721c Mon Sep 17 00:00:00 2001 From: Chester Curme Date: Fri, 10 Oct 2025 14:31:26 -0400 Subject: [PATCH 2/2] x --- libs/core/langchain_core/retrievers.py | 30 -------------------------- 1 file changed, 30 deletions(-) diff --git a/libs/core/langchain_core/retrievers.py b/libs/core/langchain_core/retrievers.py index 19fb273dffe57..b92413b054667 100644 --- a/libs/core/langchain_core/retrievers.py +++ b/libs/core/langchain_core/retrievers.py @@ -7,7 +7,6 @@ from __future__ import annotations -import warnings from abc import ABC, abstractmethod from inspect import signature from typing import TYPE_CHECKING, Any @@ -136,35 +135,6 @@ def _get_relevant_documents(self, query: str) -> list[Document]: @override def __init_subclass__(cls, **kwargs: Any) -> None: super().__init_subclass__(**kwargs) - # Version upgrade for old retrievers that implemented the public - # methods directly. - if cls.get_relevant_documents != BaseRetriever.get_relevant_documents: - warnings.warn( - "Retrievers must implement abstract `_get_relevant_documents` method" - " instead of `get_relevant_documents`", - DeprecationWarning, - stacklevel=4, - ) - swap = cls.get_relevant_documents - cls.get_relevant_documents = ( # type: ignore[method-assign] - BaseRetriever.get_relevant_documents - ) - cls._get_relevant_documents = swap # type: ignore[method-assign] - if ( - hasattr(cls, "aget_relevant_documents") - and cls.aget_relevant_documents != BaseRetriever.aget_relevant_documents - ): - warnings.warn( - "Retrievers must implement abstract `_aget_relevant_documents` method" - " instead of `aget_relevant_documents`", - DeprecationWarning, - stacklevel=4, - ) - aswap = cls.aget_relevant_documents - cls.aget_relevant_documents = ( # type: ignore[method-assign] - BaseRetriever.aget_relevant_documents - ) - cls._aget_relevant_documents = aswap # type: ignore[method-assign] parameters = signature(cls._get_relevant_documents).parameters cls._new_arg_supported = parameters.get("run_manager") is not None if (