Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11065: tenant_id not found when login via ADMIN_KEY #11066

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fixes #11065: tenant_id not found when login via ADMIN_KEY #11066

merged 1 commit into from
Nov 27, 2024
+9 −2

Conversation

lotabout
Copy link
Contributor

@lotabout lotabout commented Nov 25, 2024 •
edited by crazywoola
Loading

Summary

load_user_from_request is not called when logging in via ADMIN_KEY, which causes contexts.tenant_id to remain unset.

Close #11065

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 25, 2024
@lotabout
Fixes langgenius#11065: tenant_id not found when login via ADMIN_KEY
bd032c1 
`load_user_from_request` is not called when logging in via ADMIN_KEY, which causes `contexts.tenant_id` to remain unset.
laipz8200
laipz8200 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2024
@laipz8200 laipz8200 merged commit 6f418da into langgenius:main Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

@GarfieldDai GarfieldDai Awaiting requested review from GarfieldDai

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LookupError: <ContextVar name='tenant_id' at 0x15b781080> when login via ADMIN_API_KEY
2 participants
@lotabout @laipz8200