Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http node does not support setting variables in url in the single step test #11161

Open
5 tasks done
zxbyoyoyo opened this issue Nov 27, 2024 · 1 comment · May be fixed by #10676
Open
5 tasks done

http node does not support setting variables in url in the single step test #11161

zxbyoyoyo opened this issue Nov 27, 2024 · 1 comment · May be fixed by #10676
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report

Comments

@zxbyoyoyo
Copy link

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

v0.12.1

Cloud or Self Hosted

Cloud

Steps to reproduce

image
image

✔️ Expected Behavior

automatically replace variable values in url

❌ Actual Behavior

not replace

@zxbyoyoyo zxbyoyoyo linked a pull request Nov 27, 2024 that will close this issue
12 tasks
@dosubot dosubot bot added cloud When the version is cloud and it is a bug report 🐞 bug Something isn't working labels Nov 27, 2024
Copy link

dosubot bot commented Nov 27, 2024

@zxbyoyoyo Hello! I'm here to help you with any bugs, questions, or contributions while you wait for a human maintainer. Let's tackle this together!

I found a similar unsolved discussion titled "Why this not work" which might be related to the issue you're experiencing [1].

Regarding your issue with the HTTP node not supporting variable substitution in URLs, the Dify codebase does have functionality for handling variable substitution. The HTTP node is implemented in api/core/workflow/nodes/http_request/executor.py, where the _init_url method uses the VariablePool to substitute variables in the URL [2]. Additionally, there are test cases that verify this functionality, such as the test_template function, which demonstrates variable substitution in URLs, headers, and parameters [3].

If the substitution is not working as expected, it might be worth checking if the variables are correctly defined and accessible in the VariablePool. If the issue persists, reviewing the test cases might provide insights into how the substitution is intended to work.

To continue talking to Dosu, mention @dosu.

@crazywoola crazywoola changed the title http node , not support setting variables in url http node does not support setting variables in url Nov 27, 2024
@laipz8200 laipz8200 changed the title http node does not support setting variables in url http node does not support setting variables in url in the single step test Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working cloud When the version is cloud and it is a bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant