Linear approximation for pipe headloss and new problem for simulations #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressure is supposed to decrease with withdrawal of gas
Added lrwp version of the pipe weymouth constraint. Created a new ogf problem by replacing the compressor power objective with the difference in the squared pressures at the compressor end points
Replacing the nonlinear compressor power objective with a linear proxy, which is the absolute value of the pressure difference at the compressors endpoints
Updating the description of the new objective that uses a proxy for the compressor power
Adding a linear approximation for pipe head loss. Replacing the problem ogf_compr_power_proxy by ogf_comp_power_and_pipe_proxy to help the simulator
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 79.43% 79.25% -0.18%
==========================================
Files 38 38
Lines 5494 5519 +25
==========================================
+ Hits 4364 4374 +10
- Misses 1130 1145 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a linear approximation for pipe headloss.
Replaced the problem "ogf_comp_power_proxy" with ogf_comp_power_pipe_proxy" for use with the simulator.
All tests passed