Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regula_falsi solver does not respect regions of validity #450

Open
Yurlungur opened this issue Dec 24, 2024 · 3 comments
Open

regula_falsi solver does not respect regions of validity #450

Yurlungur opened this issue Dec 24, 2024 · 3 comments
Labels
bug Something isn't working Robustness Ensures that existing features work as intended

Comments

@Yurlungur
Copy link
Collaborator

I discovered in #449 that the regula_falsi solver does not respect the bounds of the equation of state. This isn't a problem for equations of state that are robust against out-of-bounds calls. However several of the analytic equations of state are quite brittle. In those cases, it is better to use the original findRoot method I wrote. We may wish to make regula_falsi more robust at some point.

@Yurlungur Yurlungur added bug Something isn't working Robustness Ensures that existing features work as intended labels Dec 24, 2024
@jhp-lanl
Copy link
Collaborator

jhp-lanl commented Jan 2, 2025

I think we often call it without bounds right? Maybe the overload with bounds should just respect the bounds and error out if they don't bound the solution.

@Yurlungur
Copy link
Collaborator Author

It needs bounds to initialize, as the algorithm is closer to bisection than Newton. But they appear not to be hard bounds. I wonder if we should add an optional argument that enforces the bounds.

@jhp-lanl
Copy link
Collaborator

jhp-lanl commented Jan 2, 2025

Ah right. I don't know where I thought we didn't specify bounds.

Anyway, maybe we can add a flag to respect the bounds then and not try to expand them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Robustness Ensures that existing features work as intended
Projects
None yet
Development

No branches or pull requests

2 participants