You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discovered in #449 that the regula_falsi solver does not respect the bounds of the equation of state. This isn't a problem for equations of state that are robust against out-of-bounds calls. However several of the analytic equations of state are quite brittle. In those cases, it is better to use the original findRoot method I wrote. We may wish to make regula_falsi more robust at some point.
The text was updated successfully, but these errors were encountered:
I think we often call it without bounds right? Maybe the overload with bounds should just respect the bounds and error out if they don't bound the solution.
It needs bounds to initialize, as the algorithm is closer to bisection than Newton. But they appear not to be hard bounds. I wonder if we should add an optional argument that enforces the bounds.
I discovered in #449 that the
regula_falsi
solver does not respect the bounds of the equation of state. This isn't a problem for equations of state that are robust against out-of-bounds calls. However several of the analytic equations of state are quite brittle. In those cases, it is better to use the originalfindRoot
method I wrote. We may wish to makeregula_falsi
more robust at some point.The text was updated successfully, but these errors were encountered: