Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all symbols exported by our shared library are prefixed with ldb_ in CI/CD #146

Open
Ngalstyan4 opened this issue Sep 16, 2023 · 0 comments

Comments

@Ngalstyan4
Copy link
Contributor

Ngalstyan4 commented Sep 16, 2023

Bad things happen if two postgres extensions define symbols having the same name.

Make sure CI/CD fails if this is detected.
Related to #145 and can probably use the same pipeline

sidenote: you can compare what are the common symbols exported by a pair of object files like this::
comm -12 <(nm -gD ./lantern.so | awk '{print $3}'| sort ) <(nm -gD ~/pgvector/vector.so | awk '{print $3}'| sort)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant