Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bug fixes from lantz 0.3 #1

Open
3 of 8 tasks
hgrecco opened this issue Jan 8, 2019 · 6 comments
Open
3 of 8 tasks

Missing bug fixes from lantz 0.3 #1

hgrecco opened this issue Jan 8, 2019 · 6 comments

Comments

@hgrecco
Copy link
Member

hgrecco commented Jan 8, 2019

@hgrecco
Copy link
Member Author

hgrecco commented Jan 8, 2019

Regarding lantz-monitor. I am not sure if we should keep this within lantz. I have been using cutelog together with log_to_socket and is great. lantz-monitor does more than that because it understand lantz log messages. But my recomendation would be that we move this out so it can evolve independently

Regarding log_output. I am not sure what is the use of this argument. It toggles between showing the type or the value of the argument. We could just log both.

@vascotenner
Copy link

Regarding log_output. I am reading out a camera with 12mp frames at 1Gbps. I never want to log this very large datastream.

@hgrecco
Copy link
Member Author

hgrecco commented Jan 15, 2019

@vascotenner Makes sense but maybe we should add it as an standard option for all feats/actions

Specific proposal:

  1. Provide a way to log the type (instead of the value) for all input/ouput arguments.
  2. Can be toggled on definition or during execution for each feat/dictfeat/action independently
  3. Default is to log values

To resolve:

  1. Should be provide different flags for inputs and one for outputs?
  2. API?

@vascotenner
Copy link

Specific proposal:
2. Is there an easy way? In the old feats many of its settings are hidden in very highly complicated (and undocumented) dict[MISSING][MISSING] structures.

To resolve:

  1. Only one flag to log all input and output values
  2. API Proposal:
Feat(log_values=True)
"""
:param log_values: True: Include values of input and output parameters, False: Only include type in log.
"""

@hgrecco
Copy link
Member Author

hgrecco commented Jan 15, 2019

@hgrecco
Copy link
Member Author

hgrecco commented Jan 15, 2019

I have pushed an initial implementation to pimpmyclass here

If will test it more and if I am happy I will make a new release and use it in lantz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants