-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lag when sending commands to AC #53
Comments
Hi Lanwin, I found a solution related to this issue and have been testing it for the past two days. I plan to finalize it and submit a Pull Request today. I wanted to check with you first—do you have any updates on your end? |
No. But I think there was a compensation in NonNASA if I remind me correctly. My wish would be that the solution is not that complicated :D |
No, it's not too complicated. I wrote a simple loop to check the incoming and outgoing data to see if there are any changes. So far, my tests have shown no issues, but I'll be testing more throughout the day. I had submitted another PR earlier; once that gets approved, I'll submit this one as well. |
My plan to solve this was to within the components to ignore incoming values unti the dest value was reached or until a timeout occured. |
I seem to have solved the problem with the code below, but I need to test it in detail.
|
Hi Lanwin, If you could check and approve my pending PR, I'll merge this new adjustment and create a new PR. It worked flawlessly on my end; I used to have to click the power button 2-3 times occasionally, but now it works perfectly. Similarly, there were issues when switching between modes where the command wouldn’t be received or wouldn’t notify me after being received—this adjustment seems to have fixed that issue as well. I’m eagerly waiting for your response :) |
When any values is changed, it takes a few seconds until the AC executes it. In this time it can happen that the AC sends messages with the old values to the UI witch causes it to switch back to the old states before the AC executes it and the new values get visible.
We should change that so the UI skips messages for changed values until the new values appears (or a timeout happens).
The text was updated successfully, but these errors were encountered: