Handle UI Update Issues - Improved Value Change Handling in Samsung AC Integration #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ludes and redundant code
…used includes and redundant code
lanwin
requested changes
Aug 30, 2024
- Introduced DeviceStateTracker class to handle state changes and timeout management. - Refactored samsung_ac.h and samsung_ac.cpp to use DeviceStateTracker instead of manual state tracking. - Removed old state tracking variables and methods, replaced with DeviceStateTracker integration.
Thank you! I appreciate your kind words. I'm always open to learning and sharing experiences. Collaborating on code development is always a productive experience. |
|
@omerfaruk-aran |
|
Yes I plan to merge this. But I just hand to many other stuff going, so I hand no time to review the changes again. But hope to do it soon. |
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces enhancements to the Samsung AC integration, specifically addressing the UI update issues related to value changes. The core improvement lies in handling mode changes and ensuring that the interface accurately reflects the current state of the devices.
Key Changes:
Value Change Detection: A mechanism has been implemented to detect changes in the device modes. If a change is detected, it triggers an update while also keeping track of pending changes to ensure consistency.
Timeout Handling: Introduced a timeout period (750ms) to handle cases where the value might be stale or hasn't updated in time. This helps in forcefully updating the interface if required.
Enhanced Debug Logging: Improved logging to provide better insights into the device state and update process. This includes logging when the value changes, when a stale value is detected, and when a timeout forces an update.
Data Processing Initialization: Ensured that data processing only begins after the first update, avoiding premature data handling issues.
These changes are designed to provide a more responsive and reliable interface, particularly in environments with multiple devices.