Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_request after cmd 21 (src:00 dst:c8) #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dansck
Copy link

@dansck dansck commented Feb 22, 2024

I have Samsung AC090HCADNH and there is no match command for send requests after a lage gap.
There is a lage gap after cmd 21 (src:00 dst:c8), i added this match to send requests.

@lanwin
Copy link
Collaborator

lanwin commented Feb 22, 2024

@dansck thank you for that pullrequest!

@matthias882 could you please have a look at this?

@matthias882
Copy link
Contributor

Negativ. In my setup ist no gap, directly after the cmd21-message from indoor-unit 00 the outdoor-unit send a request to indoor-unit 01. between this 2 messages are only ~70ms of free space. I tried to put our contoll-message in there but with no success.

I think in the setup of dansck is only one indoor unit?

@dansck
Copy link
Author

dansck commented Feb 22, 2024

Negativ. In my setup ist no gap, directly after the cmd21-message from indoor-unit 00 the outdoor-unit send a request to indoor-unit 01. between this 2 messages are only ~70ms of free space. I tried to put our contoll-message in there but with no success.

I think in the setup of dansck is only one indoor unit?

yes i have only 1 indoor unit, and in my setup this is the only long gap, and two matching commands in your code never happen.

@matthias882
Copy link
Contributor

in my setup are 3 long gaps.

  1. after src:C8 dst:D0 cmd:C6 (the message to D0 only appears when SNET was activated)
  2. after src:C8 dst:F0 cmd:F8
  3. after src:C8 dst:AD cmd:D1

@matthias882
Copy link
Contributor

cmd:C6 is already implemented in Line 519.
Sending after cmd:21 leads to a collision on bus and this causes the bus-communication to stop for some seconds in systems with more than 1 indoor-unit.

the correct way would be to send after cmd:C6. For this we need to investigate how to start this polling from master like it the SNET-software does.

@lanwin
Copy link
Collaborator

lanwin commented Mar 4, 2024

@matthias882 its a petty simple message to turn that on. I send it to you in one of the other threads. Not sure yet witch one it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants