-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automatic Cleaning Mode and Logging Features to Samsung AC Integration #160
Conversation
…ented debug_log_messages functionality, and corrected repository source address in the YAML file.
…tring formatting in ESP_LOGW calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that pullrequest!
…er performance in protocol_nasa.cpp
…er performance in protocol_nasa.cpp
… other values in protocol_nasa.h
Requested changes have been implemented, please review the updates. |
Thank you! |
Wow, thanks @omerfaruk-aran . May I know how you actually figured this out? Could we use something similar for the #144 sound? |
@hnykda only when we found the corresponding messages...but for now we have no hint. |
This pull request introduces the automatic cleaning mode to the Samsung AC integration, enhancing the functionality and ensuring a more hygienic environment.
Key Features:
- Automatic Cleaning Mode:
- Logging Enhancements:
Changes Made Based on Previous Feedback:
This PR addresses and resolves the issues raised in the previous pull request and is now ready for review.