Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic Cleaning Mode and Logging Features to Samsung AC Integration #160

Merged
merged 17 commits into from
Aug 22, 2024

Conversation

omerfaruk-aran
Copy link
Owner

This pull request introduces the automatic cleaning mode to the Samsung AC integration, enhancing the functionality and ensuring a more hygienic environment.

Key Features:

- Automatic Cleaning Mode:

  • Ensures hygienic drying of all moisture in the indoor unit after the cooling process is completed, providing an added layer of cleanliness and efficiency.

- Logging Enhancements:

  • debug_log_messages: This option allows for logging of all defined messages. When enabled (true), all standard log messages will be recorded, providing a clear overview of system operations.
  • debug_log_undefined_messages: This option logs any undefined messages, helping in debugging and identifying any unexpected or unhandled operations.
  • If both debug_log_messages and debug_log_undefined_messages are set to false, only the logs for the operations executed via SmartThings will be visible. This approach minimizes unnecessary log clutter while still providing essential logging for new features and functions.

Changes Made Based on Previous Feedback:

  • Resolved all conflicts.
  • Fixed indentation issues for better code readability.
  • Renamed log parameters to start with debug_ for consistency with existing log options.
  • Implemented the debug_log_messages functionality that was previously missing.
  • Corrected the repository source address in the example YAML file.

This PR addresses and resolves the issues raised in the previous pull request and is now ready for review.

…ented debug_log_messages functionality, and corrected repository source address in the YAML file.
Copy link
Collaborator

@lanwin lanwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that pullrequest!

components/samsung_ac/protocol.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol.h Outdated Show resolved Hide resolved
components/samsung_ac/protocol_nasa.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol_nasa.h Outdated Show resolved Hide resolved
components/samsung_ac/protocol_non_nasa.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol_nasa.cpp Outdated Show resolved Hide resolved
components/samsung_ac/protocol_nasa.cpp Outdated Show resolved Hide resolved
@omerfaruk-aran
Copy link
Owner Author

Requested changes have been implemented, please review the updates.

@lanwin lanwin merged commit 0e3463e into omerfaruk-aran:main Aug 22, 2024
@lanwin
Copy link
Collaborator

lanwin commented Aug 22, 2024

Thank you!

@hnykda
Copy link
Contributor

hnykda commented Aug 22, 2024

Wow, thanks @omerfaruk-aran . May I know how you actually figured this out? Could we use something similar for the #144 sound?

@lanwin
Copy link
Collaborator

lanwin commented Aug 22, 2024

@hnykda only when we found the corresponding messages...but for now we have no hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NASA] Automatic Cleaning
3 participants