Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative input values are not treated (right?) #1

Open
LucasF27 opened this issue Mar 6, 2018 · 2 comments
Open

Negative input values are not treated (right?) #1

LucasF27 opened this issue Mar 6, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@LucasF27
Copy link

LucasF27 commented Mar 6, 2018

This could lead to unpredictable (and dangerous) behavior.

@georgebrindeiro
Copy link
Member

You're right. I'll try to create a few unit tests to simulate this (and other) type(s) of input and attempt to make it safer. Do you have any specific scenario in mind?

@georgebrindeiro georgebrindeiro self-assigned this Mar 6, 2018
@georgebrindeiro georgebrindeiro added the enhancement New feature or request label Mar 6, 2018
@LucasF27
Copy link
Author

LucasF27 commented Mar 7, 2018

I noticed it when I tested the Rowing system yesterday. I did not have the stimulator pluged in, but the Arduino board accepted negative values (I created an issue there too) and it could send them to the stimulator in case it was all connected.

As the last safety measure is the stimulator node, we should meake sure it is treated there.

I recommend stopping the stimulation if it receives a negative value. And possibly an error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants