You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You're right. I'll try to create a few unit tests to simulate this (and other) type(s) of input and attempt to make it safer. Do you have any specific scenario in mind?
I noticed it when I tested the Rowing system yesterday. I did not have the stimulator pluged in, but the Arduino board accepted negative values (I created an issue there too) and it could send them to the stimulator in case it was all connected.
As the last safety measure is the stimulator node, we should meake sure it is treated there.
I recommend stopping the stimulation if it receives a negative value. And possibly an error message.
This could lead to unpredictable (and dangerous) behavior.
The text was updated successfully, but these errors were encountered: