Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushType doesn't work properly #88

Closed
chimit opened this issue Mar 9, 2020 · 4 comments
Closed

pushType doesn't work properly #88

chimit opened this issue Mar 9, 2020 · 4 comments

Comments

@chimit
Copy link
Contributor

chimit commented Mar 9, 2020

I'm using this package version v1.3.0 with Lumen 6 because Lumen 7 hasn't been released yet.

If I use a pushType() method to send voip notifications I get a DeviceTokenNotForTopic error. But if I change APN_BUNDLE_ID env var by adding a .voip suffix it starts working. Apparently, edamov/pushok supports this case.

ApnMessage::create()
    ->pushType('voip')
    ->badge(1)
    ->title('Incoming call')
    ->body('Something here!');
@dwightwatson
Copy link
Collaborator

I'm not sure what change needs to be made - is this an issue on our end or Pushok?

If it's an issue on our end could you please make a PR that resolves it and I'll review.

@chimit
Copy link
Contributor Author

chimit commented Mar 9, 2020

I'm not sure, so I would like to ask somebody to bring some clarity here :)

@dwightwatson
Copy link
Collaborator

We map the call to pushType straight back in to Pushok... all that magic under the hood happens in their library. I haven't used that argument myself so I don't have any additional insight unfortunately.

@chimit
Copy link
Contributor Author

chimit commented Mar 24, 2020

This issue can be closed as long as the problem is fixed by #92

@chimit chimit closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants