improve register function in Illuminate\Foundation\Application class

[kleninmaxim]

This is discussion about that piece of code:

framework/src/Illuminate/Foundation/Application.php

Line 751 in a88e2d3

public function register($provider, $force = false)

Can we improve that code?

        if (property_exists($provider, 'bindings')) {
            foreach ($provider->bindings as $key => $value) {
                $this->bind($key, $value);
            }
        }

        if (property_exists($provider, 'singletons')) {
            foreach ($provider->singletons as $key => $value) {
                $key = is_int($key) ? $value : $key;

                $this->singleton($key, $value);
            }
        }

Like so:

        if (property_exists($provider, 'bindings')) {
            foreach ($provider->bindings as $key => $value) {
                $this->bind(is_int($key) ? $value : $key, $value);
            }
        }

        if (property_exists($provider, 'singletons')) {
            foreach ($provider->singletons as $key => $value) {
                $this->singleton(is_int($key) ? $value : $key, $value);
            }
        }

1. $this->bind($key, $value) change as $this->singleton with verification is_int($key)
2. Inline variable $key to reduce lines of code and increase readability