Interacting with the database in the test teardown after calling the parent teardown is broken

[rikvdh]

Laravel Version

10.37.1

PHP Version

8.2.11

Database Driver & Version

MySQL

Description

When overriding teardown to cleanup something in your tests the behavior is now broken in v10.37.1 due to the changes with #49327 , the database connection is gone.

imo behavioural changes like this are never allowed in bugfix-releases.

   │ Illuminate\Contracts\Container\BindingResolutionException: Target class [config] does not exist.
   │
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:912
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:795
   │ /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:955
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:731
   │ /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:940
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:1454
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:170
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:136
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:101
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1819
...

Steps To Reproduce

    public function tearDown(): void
    {
        parent::tearDown();
        $this->model->delete();
    }

[driesvints]

Sorry about that. We'll revert it: #49361

[mpyw]

@rikvdh I think this is expected behavior:

• parent::setUp() must be called first

  public function setUp(): void
  {
      parent::setUp();
      // Your Code Goes Here
  }

• parent::tearDown() must be called later

  public function tearDown(): void
  {
      // Your Code Goes Here
      parent::tearDown();
  }

While this was a significant change, your original code has a major problem.

@driesvints @taylorotwell Why did you closed #49362?

[mpyw]

It is odd that model deletion works after parent::tearDown(), since facades are deactivated after parent::tearDown().

• This doesn't work:

  public function tearDown(): void
  {
      parent::tearDown();
      DB::table($this->model->getTable())->where('id', $this->model->id)->delete();
  }

• UNEXPECEDLY this works:

  public function tearDown(): void
  {
      parent::tearDown();
      $this->model->delete();
  }

[rikvdh]

@mpyw

.. your original code has a major problem.

It might not be, by definition, my code, if you have 100's of testcases with 1000+ tests written by 10+ developers over the past 10 years things like this slip in. "My code" has 100's of 'major problems' every day, and fixing up 10 year old tests because behavioral changes in a bugfix release is no fun.

[mpyw]

@rikvdh It is hard to deal with code that is several years old, and I understand your difficulty. I do feel you are correct to the point where it was reverted once by this report, as it was certainly unexpected as a fix to 10.x. However, I felt it was odd that the resubmission for 11.x was reverted, so I raised a discussion. Thank you for your cooperation.

• [Tests] How do we fix connection leaks when using `DatabaseTruncation` or `DatabaseMigrations`? #49373