validation message placeholder is not replaced

[Treggats]

Laravel Version

10.42.0

PHP Version

8.3

Database Driver & Version

No response

Description

Scenario
Validate a password that fails the max rule.

Using the following password validation settings;

Password::defaults(
    Password::min(8)
        ->max(100)
);

Which results in the following error message

The password must not be greater than :max characters.

The :max placeholder is not replaced.

Steps To Reproduce

Currently this test fails

public function test_password_validation_message(): void
{
    $validationMessage = Validator::make(
        data: ['password' => str_repeat('o', 101)],
        rules: ['password' => Password::default()])
            ->messages()
            ->first();

    self::assertNotSame('The password must not be greater than :max characters.', $validationMessage);
}

Changing \Illuminate\Validation\Rules\Password::max() into this makes this test pass.

    public function max($size)
    {
        $this->max = $size;

        $this->customRules = [
            ...$this->customRules,
            'max:'.$size,
        ];

        return $this;
    }

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[crynobone]

PR #49861 has been merged.