Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install:broadcasting always publishes Reverb Echo file #50440

Closed
yoeriboven opened this issue Mar 9, 2024 · 1 comment
Closed

install:broadcasting always publishes Reverb Echo file #50440

yoeriboven opened this issue Mar 9, 2024 · 1 comment
Labels
enhancement

Comments

@yoeriboven
Copy link
Contributor

yoeriboven commented Mar 9, 2024 •
edited
Loading

Laravel Version

11.x

PHP Version

8.3

Database Driver & Version

No response

Description

I'm using L11 with Pusher.

When running php artisan install:broadcasting I opted out of installing Reverb. It still published echo.js with the Reverb configuration.

In Illuminate\Foundation\Console\BroadcastingInstallCommand it doesn't seem to take this decision in account.

Steps To Reproduce

Run php artisan install:broadcasting and don't install Reverb.
crynobone added a commit that referenced this issue Mar 11, 2024
@crynobone
[11.x] Allow install:broadcasting to populate echo.js configuration
8938ecc 
either with or without Reverb

fixes #50440

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone mentioned this issue Mar 11, 2024
Closed
@crynobone crynobone linked a pull request Mar 11, 2024 that will close this issue
[11.x] Allow install:broadcasting to populate echo.js configuration either with or without Reverb #50449
Closed
crynobone added a commit that referenced this issue Mar 11, 2024
@crynobone
[11.x] Allow install:broadcasting to populate echo.js configuration
4968875 
either with or without Reverb

fixes #50440

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone mentioned this issue Mar 11, 2024
Closed
@crynobone
Copy link
Member

See #50455 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@crynobone @yoeriboven