Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 Implicitly marking parameter $specificity as nullable is deprecated tijsverkoyen/css-to-inline-styles #53828

Open
mralston opened this issue Dec 10, 2024 · 3 comments

Comments

@mralston
Copy link

Laravel Version

11.34.2

PHP Version

8.4.1

Database Driver & Version

MySQL 8.0.31-google (Google-managed Cloud SQL)

Description

Laravel requires tijsverkoyen/css-to-inline-styles. The latest version of this package throws deprecation warnings on PHP 8.4.

PHP Deprecated:  TijsVerkoyen\CssToInlineStyles\Css\Property\Processor::convertToObject(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead in vendor/tijsverkoyen/css-to-inline-styles/src/Css/Property/Processor.php on line 69
PHP Deprecated:  TijsVerkoyen\CssToInlineStyles\Css\Property\Processor::convertArrayToObjects(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead in vendor/tijsverkoyen/css-to-inline-styles/src/Css/Property/Processor.php on line 94
PHP Deprecated:  TijsVerkoyen\CssToInlineStyles\Css\Property\Property::__construct(): Implicitly marking parameter $specificity as nullable is deprecated, the explicit nullable type must be used instead in vendor/tijsverkoyen/css-to-inline-styles/src/Css/Property/Property.php on line 30

I realise this is an issue for the maintainer of that package to fix, but the last activity on the project was 5 months ago, so I'm not optimistic of a quick fix from them.

Steps To Reproduce

  1. Create a Laravel 11 application
  2. Create a Markdown Mailable
  3. Create a Console Command to send the mail
  4. Run the Console Command
@Jubeki
Copy link
Contributor

Jubeki commented Dec 10, 2024

This problem was fixed 5 months ago, it just wasn't releases yet:
tijsverkoyen/CssToInlineStyles@698d3de

There is also an open issue which asks for the release:

@mralston
Copy link
Author

Yeah, I'd seen that issue. I guess it just became a bit more urgent...

@crynobone
Copy link
Member

@mralston Can you share your config/logging.php file and .env related to logs (please remove any secret keys etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants