Remove baseUrl parameter from DeployCommand

Co-authored-by: Jess Archer <[email protected]>

Author: sbourouis

config/nightwatch.php

@@ -5,7 +5,6 @@
     'token' => env('NIGHTWATCH_TOKEN'),
     'deployment' => env('NIGHTWATCH_DEPLOY'),
     'server' => env('NIGHTWATCH_SERVER', (string) gethostname()),
-    'base_url' => env('NIGHTWATCH_BASE_URL', 'https://nightwatch.laravel.com'),
     'capture_exception_source_code' => env('NIGHTWATCH_CAPTURE_EXCEPTION_SOURCE_CODE', true),
     'redact_headers' => explode(',', env('NIGHTWATCH_REDACT_HEADERS', 'Authorization,Cookie,Proxy-Authorization,X-XSRF-TOKEN')),
 

src/Console/DeployCommand.php

@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-#[AsCommand(name: 'nightwatch:deploy', description: 'Notice the Nightwatch agent that a new deployment has been made.')]
+#[AsCommand(name: 'nightwatch:deploy', description: 'Notify Nightwatch of a deployment.')]
 final class DeployCommand extends Command
 {
     /**
@@ -27,11 +27,10 @@ final class DeployCommand extends Command
     /**
      * @var string
      */
-    protected $description = 'Notice the Nightwatch agent that a new deployment has been made.';
+    protected $description = 'Notify Nightwatch of a deployment.';
 
     public function __construct(
         private HttpFactory $http,
-        private ?string $baseUrl,
         #[SensitiveParameter] private ?string $token,
     ) {
         parent::__construct();
@@ -41,11 +40,7 @@ public function handle(): void
     {
         $tag = config('nightwatch.deployment') ?? '';
 
-        if (! $this->baseUrl) {
-            $this->error('No Nightwatch base URL configured.');
-
-            return;
-        }
+        $baseUrl = $_SERVER['NIGHTWATCH_BASE_URL'] ?? 'https://nightwatch.laravel.com';
 
         if (! $this->token) {
             $this->error('No Nightwatch token configured.');
@@ -60,7 +55,7 @@ public function handle(): void
                     'Accept' => 'application/json',
                     'Content-Type' => 'application/json',
                 ])
-                ->post("{$this->baseUrl}/api/deployments", [
+                ->post("{$baseUrl}/api/deployments", [
                     'timestamp' => now()->timestamp,
                     'version' => $tag,
                 ]);

src/NightwatchServiceProvider.php

@@ -233,7 +233,6 @@ private function registerDeployCommand(): void
         $this->app->singleton(DeployCommand::class, fn () => new DeployCommand(
             http: $this->app->make(\Illuminate\Http\Client\Factory::class),
             token: $this->nightwatchConfig['token'] ?? null,
-            baseUrl: $this->nightwatchConfig['base_url'] ?? null,
         ));
     }