-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation Warnings - PHP 8.4 #311
Comments
The underlying library PHP-CS-Fixer is currently working on PHP 8.4 compatibility (this does not include PHP 8.4 syntax specific fixers). Furthermore is Laravel Pint working on PHP 8.4 compatibility: Because this is a CLI tool and not Laravel/Illuminate directly, it is also waiting on laravel-zero to be compatible with PHP 8.4. |
Hey, I understand. I knew you guys were working on it before I tagged PR 304; I just wasn't sure what was preventing Herd from updating the illuminate dependencies to a version without implicit nulls. Thank you for clearing it up |
Duplicate of #304 Let's just monitor the status using the posted PR. |
Pint Version
1.18.3
PHP Version
8.4
Description
Summary
I've not read previous PRs or Issues fully; I apologise for missing anything.
Running Pint generates numerous deprecation warnings. The warnings are about implicitly declaring a type as nullable in a parameter.
The warnings stem from using outdated Illuminate/* packages that implementations of implicitly null types.
Potential solution
Both laravel 10 and 11 have recently released versions addressing the deprecation of implicit null parameters.
Laravel 11
Laravel 10
If there are no blockers, publishing a release with updated dependencies would make sense.
Example Output
I've only included 2 of the 50+ warnings. Including more isn't necessary.
Related:
#304 #310
Steps To Reproduce
Install pint using PHP8.4.
Run ./vendor/bin/pint
See Warnings
The text was updated successfully, but these errors were encountered: