Skip to content

[Bug]: Double quotes does not trigger the autocomplete #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ldriko opened this issue Mar 17, 2025 · 4 comments · May be fixed by laravel/vs-code-php-parser-cli#20
Open

[Bug]: Double quotes does not trigger the autocomplete #339

ldriko opened this issue Mar 17, 2025 · 4 comments · May be fixed by laravel/vs-code-php-parser-cli#20
Assignees
@joetannenbaum
Labels
bug

Comments

@ldriko
Copy link

ldriko commented Mar 17, 2025 •
edited
Loading

Extension Version

1.0.5

PHP Binary

Local PHP

Operating System

Linux (WSL)

What happened?

It seems that double quotes are also registered as a trigger yet it does not trigger the autocompete like single quote does.

Image
@ldriko ldriko added the bug label Mar 17, 2025
@xerox0213
Copy link

I don't know if it is a bug but anyway, it would be great to have auto completion inside double quotes

@ldriko
Copy link
Author

ldriko commented Mar 25, 2025

Based on this line of code and it's been there since the first commit so I'm assuming that it is some kind of bug. Not quite sure how it works though.

vs-code-extension/src/extension.ts

Line 75 in 55a209f

const TRIGGER_CHARACTERS = ["'", '"'];

@N1ebieski N1ebieski linked a pull request Apr 22, 2025 that will close this issue
Open
@N1ebieski
Copy link
Contributor

laravel/vs-code-php-parser-cli#20

@xerox0213
Copy link

@N1ebieski Thanks bro 👍🏼 ! That bug is so annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joetannenbaum joetannenbaum

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Double quotes does not trigger the autocomplete N1ebieski/vs-code-php-parser-cli
4 participants
@joetannenbaum @N1ebieski @ldriko @xerox0213