Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metrics to adhere to Prometheus metric naming conventions #5

Open
stanhu opened this issue May 1, 2018 · 1 comment
Open

Comments

@stanhu
Copy link

stanhu commented May 1, 2018

Thanks for this project! We're looking at shipping a PgBouncer exporter in GitLab but noticed the metric names in this exporter don't adhere to Prometheus naming conventions: https://prometheus.io/docs/practices/naming/

https://github.com/spreaker/prometheus-pgbouncer-exporter#exported-metrics is an example of how the metrics should be named.

The avg queries can probably also be omitted as well, since Prometheus can calculate averages over any time period needed.

@larseen
Copy link
Owner

larseen commented May 1, 2018

Yeah, agree with the points made, unfortunately the project have not seen some work in some time.
You are welcome to make a Pull Request If you like!

ferringb pushed a commit to ferringb/pgbouncer_exporter that referenced this issue Jan 22, 2019
Metric name stays the same, but the data now gets multiplied to seconds.

Note: this doesn't fix larseen#5, but is a step in that direction- the exporter now
uses prometheus standardized units.  Renaming is a follow up exercise.
ashokraj pushed a commit to ashokraj/pgbouncer_exporter that referenced this issue May 8, 2019
Switch to kingpin for flag handling and enable log flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants