Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.6 also works with this but composer.json prevents using #9

Open
softvar opened this issue Jun 15, 2020 · 1 comment
Open

PHP 5.6 also works with this but composer.json prevents using #9

softvar opened this issue Jun 15, 2020 · 1 comment

Comments

@softvar
Copy link

softvar commented Jun 15, 2020

I'm using PHP 5.6 in my project. I have been using this library by copy-pasting the code and it works. I wanted to use it via composer but composer.json requires to have PHP 7+.

Can we please update the composer.json to support 5.6 as well because code is working fine.

Thanks!

@afk11
Copy link
Contributor

afk11 commented Jun 19, 2020

You mustn't be copy-pasting master or a recent version, because this https://github.com/lastguest/murmurhash-php/blob/master/src/lastguest/Murmur.php#L24 (master) won't work on 5.6 for sure.

version 1.2.0 should work with 5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants