Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EO v5.0.0-beta1 msg Order #9638 cannot be edited. Its shipping_tax_rate was not previously recorded.log #275

Open
OldNGreyBMR opened this issue Jan 11, 2025 · 4 comments
Open

EO v5.0.0-beta1 msg Order #9638 cannot be edited. Its shipping_tax_rate was not previously recorded.log #275

OldNGreyBMR opened this issue Jan 11, 2025 · 4 comments
Labels
beta-bug Bug, specific to a beta release retest requested Request that the issue be retested
Milestone
v5.0.0-beta2

Comments

@OldNGreyBMR
Copy link

zc2.1.0 PHP 8.3
Editing an order gives Msg: Order #9638 cannot be edited. Its shipping_tax_rate was not previously recorded.

zc1.5.8a Edit orders V4.7.0-beta2 using same data in 1.5.8 shows tax rate 10%
@lat9
Copy link
Owner

lat9 commented Jan 11, 2025

EO-5's a bit more particular. As mentioned in the discussion, if the site's tax-titles don't include the associated tax-rate (e.g. Sales Tax (25%):) then EO-5's not going to attempt to 'find' the associated ot_tax recrod.

@lat9
Copy link
Owner

lat9 commented Jan 12, 2025

Could you provide a screenshot of order#9638 as displayed in the admin's Orders details?

@lat9
Copy link
Owner

lat9 commented Jan 13, 2025

Crud, I thought that orders::shipping_tax_rate was added in zc158. I was wrong, it was added in zc200.

I'll need to rethink EO-5's approach to that value's determination if not previously set.

@lat9 lat9 added the beta-bug Bug, specific to a beta release label Jan 13, 2025
@lat9 lat9 added this to the v5.0.0-beta2 milestone Jan 13, 2025
lat9 added a commit that referenced this issue Jan 14, 2025
@lat9
#280: Corrections to shipping cost when inclusive of tax
a0053f8 
If prices are displayed with tax, the shipping cost already includes its associated tax and that's the value that is carried forward as the order's shipping cost (used by ot_shipping).

This commit also contains some staging of corrections for #275, keeping some modicum of sanity on the initial recording of an order's shipping-tax-rate.
lat9 added a commit that referenced this issue Jan 16, 2025
@lat9
#275: Initialize order's shipping tax-rate if not previously set.
7b776af
lat9 added a commit that referenced this issue Jan 16, 2025
@lat9
Merge pull request #285 from lat9/shipping-tax-rate-init
11a5f3e 
#275: Initialize order's shipping tax-rate if not previously set.
@lat9
Copy link
Owner

lat9 commented Jan 16, 2025

EO now initializes an order's shipping tax-rate (with a hidden status-message indicating as such).

When verifying, please pull all files from the 5.0.0 branch.

@lat9 lat9 added the retest requested Request that the issue be retested label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta-bug Bug, specific to a beta release retest requested Request that the issue be retested
Projects
None yet
Milestone
v5.0.0-beta2
Development

No branches or pull requests
2 participants
@lat9 @OldNGreyBMR