Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-processing] Electron SF variations are identical #47

Open
mlizzo opened this issue Oct 17, 2024 · 0 comments
Open

[post-processing] Electron SF variations are identical #47

mlizzo opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mlizzo
Copy link

mlizzo commented Oct 17, 2024

Electron SF variations appear to be identical and I think the issue is due to a small bug in the LeptonSF.py module, in particular by line#455. Indeed, when the isPOGFormat flag is true, the second term under the sqrt is always EleRecoSF_tmp[1]*EleRecoSF_tmp[1], which corresponds to the upwards Electron_RecoSF variation. When the downwards variation is computed, that term should be EleRecoSF_tmp[2]*EleRecoSF_tmp[2] instead.

FYI: @BlancoFS @giorgiopizz @NTrevisani @dittmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant