Skip to content

Commit 7cb8727

Browse files
committed
Don't stop the multi-manager on bad request.
1 parent 7c99f51 commit 7cb8727

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

libs/networking/src/curl_multi_manager.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,10 @@ int CurlMultiManager::socket_callback(CURL* easy,
112112
auto [it, inserted] = manager->sockets_.try_emplace(
113113
s, SocketInfo{s, nullptr, 0});
114114
if (!manager->start_socket_monitor(&it->second, what)) {
115-
// Failed to start monitoring - return error to CURL
116-
return -1;
115+
// Failed to register socket monitoring. No data received from the
116+
// socket will eventually cause a timeout.
117+
// We don't want to return -1, because multiple requests can be
118+
// using the same multi-manager.
117119
}
118120
}
119121

0 commit comments

Comments
 (0)