fix: [REL-10522] update mount so it cleans up toolbar styles #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launchdarkly-upra
bot
changed the title
pranjal-jately-ld
approved these changes
Nov 3, 2025
Contributor
pranjal-jately-ld
left a comment
pranjal-jately-ld
left a comment
There was a problem hiding this comment.
Thanks for the quick fix 🙏 🚀
Contributor
|
Closing this as we've addressed the issue in the following PR - #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the toolbar is mounted, it loads all of it's related styling into the
document.head. From there, we copy that and place all toolbar styles into the Shadow DOM it is hosted in. However, we were not cleaning up those styles, so they were causing issues in gonfalon where styling would be inadvertently overriden.What does this PR do?
Have
mount.tsxclean up styling after placing it in the Shadow DOM so it won't override the styling of the host application.Type of Change
Related Jira issue: REL-10522: Developer Toolbar overriding styles in gonfalon