Skip to content

Commit 8bc24d4

Browse files
authored
chore: remove remix app (#1189)
1 parent ace1297 commit 8bc24d4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

75 files changed

+104
-3063
lines changed

.changeset/config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
1111
"onlyUpdatePeerDependentsWhenOutOfRange": true
1212
},
13-
"ignore": ["@launchpad-ui/remix"]
13+
"ignore": []
1414
}

.github/workflows/verify.yml

-96
Original file line numberDiff line numberDiff line change
@@ -79,102 +79,6 @@ jobs:
7979
- name: Test
8080
run: pnpm test:packages
8181

82-
e2e:
83-
name: e2e
84-
needs: [branch-info]
85-
runs-on: ubuntu-latest
86-
steps:
87-
- uses: actions/checkout@v4
88-
with:
89-
fetch-depth: 0
90-
91-
- uses: pnpm/action-setup@v3
92-
93-
- name: Derive appropriate SHAs for base and head for `nx affected` commands
94-
uses: nrwl/nx-set-shas@v4
95-
with:
96-
main-branch-name: ${{needs.branch-info.outputs.base-branch}}
97-
98-
- name: Setup Node
99-
uses: actions/setup-node@v4
100-
with:
101-
node-version: 20
102-
cache: pnpm
103-
104-
- name: Install Dependencies
105-
run: pnpm install
106-
107-
- name: Get Playwright Version
108-
id: get-version
109-
run: |
110-
echo "VERSION=$(pnpm playwright --version)" >> $GITHUB_OUTPUT
111-
shell: bash
112-
113-
- name: Cache Browsers
114-
id: cache-browsers
115-
uses: actions/cache@v4
116-
with:
117-
path: ~/.cache/ms-playwright
118-
key: ${{ runner.os }}-playwright-${{ steps.get-version.outputs.VERSION }}
119-
restore-keys: |
120-
${{ runner.os }}-playwright-
121-
122-
- name: Install Playwright
123-
if: steps.cache-browsers.outputs.cache-hit != 'true'
124-
run: pnpm playwright install
125-
126-
- name: SSR
127-
run: pnpm e2e:ssr
128-
129-
- name: Upload blob report to GitHub Actions Artifacts
130-
if: always()
131-
uses: actions/upload-artifact@v4
132-
with:
133-
name: e2e-blob-reports
134-
path: blob-report
135-
retention-days: 1
136-
137-
merge-reports:
138-
# Merge reports after playwright-tests, even if some shards have failed
139-
if: always()
140-
needs: [e2e]
141-
142-
runs-on: ubuntu-latest
143-
steps:
144-
- uses: actions/checkout@v4
145-
with:
146-
fetch-depth: 0
147-
148-
- uses: pnpm/action-setup@v3
149-
150-
- name: Derive appropriate SHAs for base and head for `nx affected` commands
151-
uses: nrwl/nx-set-shas@v4
152-
153-
- name: Setup Node
154-
uses: actions/setup-node@v4
155-
with:
156-
node-version: 20
157-
cache: pnpm
158-
159-
- name: Install Dependencies
160-
run: pnpm install
161-
162-
- name: Download blob reports from GitHub Actions Artifacts
163-
uses: actions/download-artifact@v4
164-
with:
165-
name: e2e-blob-reports
166-
path: all-blob-reports
167-
168-
- name: Merge into HTML Report
169-
run: pnpm playwright merge-reports --reporter html ./all-blob-reports
170-
171-
- name: Upload HTML report
172-
uses: actions/upload-artifact@v4
173-
with:
174-
name: e2e-html-report--attempt-${{ github.run_attempt }}
175-
path: playwright-report
176-
retention-days: 14
177-
17882
typecheck:
17983
name: Type Check
18084
needs: [branch-info]

.plop/templates/component/remix-example.tsx.hbs

-7
This file was deleted.

README.md

-14
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,6 @@ The following command will build Storybook, start the server, and run a11y tests
5656
$ pnpm e2e:a11y
5757
```
5858

59-
#### SSR Tests
60-
61-
SSR support is tested using a [Remix](https://remix.run/) app [found in the monorepo](./apps/remix/README.md).
62-
63-
The following command will build the app, start the server, and run Playwright tests to verify the components have rendered:
64-
65-
```sh
66-
$ pnpm e2e:ssr
67-
```
68-
6959
## LaunchPad Architecture
7060

7161
LaunchPad is set up as a monorepo where each component package is bundled and delivered as its own NPM package. While you can technically import each component package separately, we do recommend using the "bundled" version of LaunchPad at `@launchpad-ui/core`. The team chose to treat each component as a separate package internally for improved testing, version management, and isolation guarantees.
@@ -80,10 +70,6 @@ While all LaunchPad UI components are packages, not all packages are necessarily
8070

8171
LaunchPad libraries may depend on one another, as in the case of our modal library depending on the button library. This dependency, just like with shared utility libraries, is simply represented as a package.json import.
8272

83-
### The `apps` Directory
84-
85-
The apps directory is essentially a standalone project that has easy access to our workspace packages. Currently, we have a Remix application that we use for SSR testing, but you could build other apps such as a docs website or another testing playground.
86-
8773
### Versioning
8874

8975
We are using [major version zero (0.y.z) semantic versioning](https://semver.org/spec/v0.1.0.html) to indicate that the project is still in an "initial development" phase and anything may change at any time. When a new package is introduced, the initial version is set to `0.1.0`.

apps/remix/README.md

-22
This file was deleted.

apps/remix/app/data.server.ts

-62
This file was deleted.

apps/remix/app/entry.client.tsx

-10
This file was deleted.

apps/remix/app/root.tsx

-137
This file was deleted.

0 commit comments

Comments
 (0)