Skip to content

Commit 661426e

Browse files
authored
fix: Re-export underlying launchdarkly config type (#33)
fixes #32
1 parent b0f2c61 commit 661426e

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
runs-on: ubuntu-latest
1616

1717
strategy:
18+
fail-fast: false
1819
matrix:
1920
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
2021

@@ -45,6 +46,7 @@ jobs:
4546
shell: powershell
4647

4748
strategy:
49+
fail-fast: false
4850
matrix:
4951
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
5052

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ $ pip install launchdarkly-openfeature-server
3939
### Usage
4040

4141
```python
42-
from ldclient import Config
43-
from ld_openfeature import LaunchDarklyProvider
42+
from ld_openfeature import LaunchDarklyProvider, Config
4443
from openfeature import api
4544

4645
openfeature_provider = LaunchDarklyProvider(Config("sdk-key"))

ld_openfeature/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
from ldclient.config import Config
12
from ld_openfeature.provider import LaunchDarklyProvider
23

34
__all__ = [
5+
'Config',
46
'LaunchDarklyProvider'
57
]

tests/test_provider.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from unittest.mock import patch
44

55
import pytest
6-
from ldclient import Config, LDClient
6+
from ldclient import LDClient
77
from ldclient.evaluation import EvaluationDetail
88
from ldclient.integrations.test_data import TestData
99
from openfeature.evaluation_context import EvaluationContext
@@ -12,7 +12,7 @@
1212
from openfeature.flag_evaluation import Reason
1313
from openfeature import api
1414

15-
from ld_openfeature import LaunchDarklyProvider
15+
from ld_openfeature import LaunchDarklyProvider, Config
1616
from tests.test_data_sources import FailingDataSource, StaleDataSource, UpdatingDataSource, DelayedFailingDataSource
1717

1818

@@ -115,7 +115,7 @@ def test_invalid_types_generate_type_mismatch_results(provider: LaunchDarklyProv
115115
pytest.param(['default-value'], True, ['default-value'], list, 'resolve_object_details'),
116116
pytest.param(['default-value'], 1, ['default-value'], list, 'resolve_object_details'),
117117
pytest.param(['default-value'], 'return-string', ['default-value'], list, 'resolve_object_details'),
118-
118+
119119
pytest.param({'key': 'default'}, {'key': 'return'}, {'key': 'return'}, dict, 'resolve_object_details'),
120120
pytest.param({'key': 'default'}, True, {'key': 'default'}, dict, 'resolve_object_details'),
121121
pytest.param({'key': 'default'}, 1, {'key': 'default'}, dict, 'resolve_object_details'),
@@ -137,7 +137,7 @@ def test_check_method_and_result_match_type(
137137

138138
method = getattr(provider, method_name)
139139
resolution_details = method("check-method-flag", default_value, evaluation_context)
140-
140+
141141
assert resolution_details.value == expected_value
142142
#assert isinstance(resolution_details.value, expected_type)
143143

0 commit comments

Comments
 (0)