fix: Skip empty hosts when processing NO_PROXY variable (#309)

Author: hpelwintervold

ldclient/impl/http.py

@@ -120,12 +120,15 @@ def _get_proxy_url(target_base_uri):
         return proxy_url
 
     for no_proxy_entry in no_proxy.split(','):
+        if no_proxy_entry == '':
+            continue
         parts = no_proxy_entry.strip().split(':')
         if len(parts) == 1:
             if target_host.endswith(no_proxy_entry):
                 return None
             continue
-
+        if parts[0] == '':
+            continue
         if target_host.endswith(parts[0]) and target_port == int(parts[1]):
             return None
 

ldclient/testing/impl/test_http.py

@@ -16,6 +16,9 @@
         ('https://secure.example.com', 'wrong.example.com', 'https://secure.proxy:1234'),
         ('https://secure.example.com:8080', 'secure.example.com', None),
         ('https://secure.example.com:8080', 'secure.example.com:443', 'https://secure.proxy:1234'),
+        ('https://secure.example.com:8080', 'secure.example.com:443,', 'https://secure.proxy:1234'),
+        ('https://secure.example.com:8080', 'secure.example.com:443,,', 'https://secure.proxy:1234'),
+        ('https://secure.example.com:8080', ':8080', 'https://secure.proxy:1234'),
 
         ('https://secure.example.com', 'example.com', None),
         ('https://secure.example.com', 'example.com:443', None),