Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Blank UI from switching between notes in different notebooks and unloading app #11384

Open
ImperialSquid opened this issue Nov 12, 2024 · 3 comments
Open

Mobile: Blank UI from switching between notes in different notebooks and unloading app #11384

ImperialSquid opened this issue Nov 12, 2024 · 3 comments
Labels
bug It's a bug high High priority issues mobile All mobile platforms

Comments

@ImperialSquid
Copy link

Operating system

Android

Joplin version

3.1.8

Desktop version info

Joplin Mobile 3.1.8 (prod, android)

Client ID: d94348b4ba434bb589db1fb87e33a45a
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: 41b251d (release-3.1)

AlertsPerfect: 1.0.1
Extra Markdown editor settings: 1.4.1
History Panel: 1.0.2
Kanban: 1.1.0
Link Graph UI: 1.5.0
Math Mode: 0.7.1
Note Tabs: 1.4.0
Quick Links: 1.3.2

Android API level: 34
WebView version: 130.0.6723.107
WebView package: com.google.android.webview
FTS enabled: 1
Hermes enabled: 1

Current behaviour

  1. Create two notebooks
  2. Create a note in each notebook
  3. Create a markdown link from one note to the other
  4. Open the first note
  5. Follow the link to the other
  6. Close the app (eg by pressing the home or switch app buttons on the bottom UI)
  7. Reopen the app (may need to wait a few seconds)
  8. See that UI is mostly blank

Expected behaviour

UI shouldn't break by unloading the app

Logs

No response
@ImperialSquid ImperialSquid added the bug It's a bug label Nov 12, 2024
@ImperialSquid
Copy link
Author

Here's a screenshot of the UI after following the steps above:

Screenshot_20241112_162616_Joplin

@ImperialSquid
Copy link
Author

Possibly related to the fix for #10677? Since that one was also about buggy behaviour when switching notes in different notebooks...

@ImperialSquid
Copy link
Author

Interestingly, navigating A -> B -> A then unloading doesn't seem to result in a blank UI, so the issue seems to be with the current note being in a different notebook than the first one

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms high High priority issues labels Nov 12, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Nov 12, 2024
@personalizedrefrigerator
Mobile: Fixes laurent22#11384: Fix switching notes then unloading app…
997e5f5 
… causes blank screen

This issue is caused by `Notes.tsx` removing the current note from
`state.notes` (due to not being in the current parent item). This
then causes the editor to unload.

This change needs:
- Manual testing
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Nov 16, 2024
@personalizedrefrigerator
Change approach to fixing laurent22#11384: Handle the case where sele…
fe4e200 
…ctedNoteIds is empty

This updates Note.tsx to continue showing the previous note even if
selectedNoteIds is empty, which can happen if a link or "move to folder"
action moves the current note out of the selected folder. This matches the behavior prior to the fix for
issue laurent22#10677.
Merged
laurent22 pushed a commit that referenced this issue Nov 16, 2024
@personalizedrefrigerator
Mobile: Fixes #11384: Fix switching notes then unloading app causes b…
bb66e81 
…lank screen (#11396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug high High priority issues mobile All mobile platforms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImperialSquid @personalizedrefrigerator