Chore: Desktop: Markdown editor panes: Migrate from style properties to SCSS #11423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
personalizedrefrigerator
changed the title
|
Thank you so much for this! I use similar code in my userchrome.css as referenced in your motivation link. I was annoyed that a recent update broke that css again... then I was overjoyed to find so many more classes defined to allow for better targeting specific elements. So much so that I tracked down this pull request to thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request migrates part of the Markdown editor's styling from
style=-based styling to SCSS.Motivation: This is motivated in part by the complicated styling used here to style Joplin's editor/viewer panes. Such style sheets are likely to be fragile to changes to the app's HTML structure in the future.
Screenshots
CodeMirror 6-based editor
Legacy editor (CodeMirror 5-based)