Check what happens when a note in a shared folder is deleted

[laurent22]

Ref: #11458 (comment)

---

Ok I think that makes sense to fix this particular crash then. Also to address his comment:

I own several shares that I made available to other JoplinCloud basic accounts when the ‘read only’ option was not yet available. Later, when I discovered that the ‘read only’ option was offered, I changed these shares to ‘read only’.

Could you please check what happens when a note in a shared folder is moved to the trash? Do we clear the share_id and is_shared property?

As for read-only items, I believe there are checks in place to prevent them from being deleted in general. I think it was only possible in this case maybe due to a bug with share_id not being cleared.

[personalizedrefrigerator]

The issue seems to be this query:

joplin/packages/lib/models/Folder.ts

Line 461 in c40e6ae

LEFT JOIN folders ON notes.parent_id = folders.id

Sharing the content of a notebook is based on which items have a particular parent_id. When an item is moved to the trash, it still has its original parent ID and is thus shared.