Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovak language not available to select #11535

Open
dodog opened this issue Dec 18, 2024 · 2 comments
Open

Slovak language not available to select #11535

dodog opened this issue Dec 18, 2024 · 2 comments
Labels
bug It's a bug

Comments

@dodog
Copy link
Contributor

dodog commented Dec 18, 2024

Operating system

Linux

Joplin version

3.2.5

Desktop version info

Joplin 3.2.5 (prod, linux)

Client ID: e1bf2a94c2b540c89c7a8cd353719431
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: 2da789a

Backup: 1.4.2
Freehand Drawing: 2.13.0
OCR: 0.3.2

Current behaviour

In Tools > Option > Language there is no option for Slovak language.

I tried even to hardcode Slovak locale in settings.json, but Slovak language is not loaded.

Expected behaviour

Option to select Slovak language

Logs

No response

@dodog dodog added the bug It's a bug label Dec 18, 2024
@vidipsingh
Copy link

Hi @dodog,

To add the Slovak language, we first need to create a JavaScript file for it, similar to what's available in Assets > TinyMCE > langs. This folder contains the language options for desktop, mobile, and terminal applications. Once we have the translations from English to Slovak, we can then add the respective Slovak file in:

packages/app-desktop/locales/index.js
packages/app-mobile/locales/index.js

I believe this approach would work. @laurent22, could you please provide further guidance on this? I'd be happy to contribute and work on this issue.

Thanks!

@dodog
Copy link
Contributor Author

dodog commented Dec 22, 2024

Hi @vidipsingh, I translated Joplin into Slovak about a month ago and the sk_SK.po file is already in /packages/tools/locales/. I didn't know it is necessary to do some other things to add Slovak. The @laurent22 said it should run after the po file is added. But when I look at the files mentioned, it really looks like Slovak needs to be added there as well.

Repository owner locked as off-topic and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants